I have a class the is derived from CListCtrl. There are two columns, one is 
fixed, the other is editable. I would like to make it so that characters 
entered in the editable column always appear in uppercase (much like setting 
the Uppercase property to True on a CEdit).

I've tried a number of things, but none seem to work. I am not an MFC expert 
by any means. Any help would be appreciated.

I'd start by just setting it in the edit control you get in EditLabel()

http://msdn2.microsoft.com/en-us/library/4xxsdd7z(VS.80).aspx

I haven't tried it, but I think you can call ModifyStyle()

http://msdn2.microsoft.com/en-us/library/0xhz2t1c(VS.80).aspx

With the style:

ES_UPPERCASE

http://msdn2.microsoft.com/en-us/library/6e36b89f(VS.80).aspx

Tom

"Matt Jacobi" <Matt Jacobi@discussions.microsoft.com> wrote in message 
news:1005A03F-D80A-4B3D-8A3E-6783391DB055@microsoft.com...
>I have a class the is derived from CListCtrl. There are two columns, one is
> fixed, the other is editable. I would like to make it so that characters
> entered in the editable column always appear in uppercase (much like 
> setting
> the Uppercase property to True on a CEdit).
>
> I've tried a number of things, but none seem to work. I am not an MFC 
> expert
> by any means. Any help would be appreciated. 

Tom,

Thanks so much for quick reply. However, the one thing you suggested was the 
one thing I had already tried (to no avail). However, maybe I am doing 
something wrong. Here is my code:

int SerialNumberList::InsertRow (Row& rowData) {
    [...]
    int item = InsertItem(GetItemCount(), rowData.at(1).c_str());
    SetItemText(item, 1, rowData.at(0).c_str());

    // Start New Code
    SetFocus(); // EditLabel() returns a null pointer without this for some 
reason
    CEdit* edit = EditLabel(item);
    edit->ModifyStyle(0, ES_UPPERCASE);
    // End New Code

    [...]
}

This code appears to have absolutely no effect (if I type lowercase chars, 
they appear as lowercase).

Also, since ModifyStyle() employs SetWindowLong(), I was looking at the 
documentation for SetWindowLong() and saw this: 

"Certain window data is cached, so changes you make using SetWindowLong will 
not take effect until you call the SetWindowPos function. Specifically, if 
you change any of the frame styles, you must call SetWindowPos with the 
SWP_FRAMECHANGED flag for the cache to be updated properly."

As a result, I also tried changing
edit->ModifyStyle(0, ES_UPPERCASE);
to
edit->ModifyStyle(0, ES_UPPERCASE, SWP_FRAMECHANGED);
but that didn't seem to make any difference.

Any more help/ideas would be greatly appreciated!

"Tom Serface" wrote:

> I'd start by just setting it in the edit control you get in EditLabel()
> 
> http://msdn2.microsoft.com/en-us/library/4xxsdd7z(VS.80).aspx
> 
> I haven't tried it, but I think you can call ModifyStyle()
> 
> http://msdn2.microsoft.com/en-us/library/0xhz2t1c(VS.80).aspx
> 
> With the style:
> 
> ES_UPPERCASE
> 
> http://msdn2.microsoft.com/en-us/library/6e36b89f(VS.80).aspx
> 
> Tom

It may have the same effect, but have you tried using:

http://msdn2.microsoft.com/en-us/library/c4x5de10.aspx

To get the control instead before doing the EditLabel() stuff.

Otherwise you may have to place your own edit control in there instead using 
something like:

http://www.codeguru.com/cpp/controls/listview/advanced/article.php/c4179/

Tom

"Matt Jacobi" <MattJacobi@discussions.microsoft.com> wrote in message 
news:7E87E9AF-9179-47DA-A3BD-6A09CB539BB4@microsoft.com...
> Tom,
>
> Thanks so much for quick reply. However, the one thing you suggested was 
> the
> one thing I had already tried (to no avail). However, maybe I am doing
> something wrong. Here is my code:
>
> int SerialNumberList::InsertRow (Row& rowData) {
>    [...]
>    int item = InsertItem(GetItemCount(), rowData.at(1).c_str());
>    SetItemText(item, 1, rowData.at(0).c_str());
>
>    // Start New Code
>    SetFocus(); // EditLabel() returns a null pointer without this for some
> reason
>    CEdit* edit = EditLabel(item);
>    edit->ModifyStyle(0, ES_UPPERCASE);
>    // End New Code
>
>    [...]
> }
>
> This code appears to have absolutely no effect (if I type lowercase chars,
> they appear as lowercase).
>
> Also, since ModifyStyle() employs SetWindowLong(), I was looking at the
> documentation for SetWindowLong() and saw this:
>
> "Certain window data is cached, so changes you make using SetWindowLong 
> will
> not take effect until you call the SetWindowPos function. Specifically, if
> you change any of the frame styles, you must call SetWindowPos with the
> SWP_FRAMECHANGED flag for the cache to be updated properly."
>
> As a result, I also tried changing
> edit->ModifyStyle(0, ES_UPPERCASE);
> to
> edit->ModifyStyle(0, ES_UPPERCASE, SWP_FRAMECHANGED);
> but that didn't seem to make any difference.
>
> Any more help/ideas would be greatly appreciated!
>
> "Tom Serface" wrote:
>
>> I'd start by just setting it in the edit control you get in EditLabel()
>>
>> http://msdn2.microsoft.com/en-us/library/4xxsdd7z(VS.80).aspx
>>
>> I haven't tried it, but I think you can call ModifyStyle()
>>
>> http://msdn2.microsoft.com/en-us/library/0xhz2t1c(VS.80).aspx
>>
>> With the style:
>>
>> ES_UPPERCASE
>>
>> http://msdn2.microsoft.com/en-us/library/6e36b89f(VS.80).aspx
>>
>> Tom 

Tom,

Thanks for your help. By looking at the source code of the edit control you 
pointed me to, plus some further Googling based on what I saw there, I was 
able to come up with a solution. All I had to do was override one function in 
my class.

Here is what I came up with:

BOOL SerialNumberList::PreTranslateMessage(MSG* pMsg) {
    if (pMsg->message == WM_CHAR) {
        pMsg->wParam = toupper(pMsg->wParam);
    }
    return CListCtrl::PreTranslateMessage(pMsg);
}

Thanks again for your help!
-- Matt

"Tom Serface" wrote:

> It may have the same effect, but have you tried using:
> 
> http://msdn2.microsoft.com/en-us/library/c4x5de10.aspx
> 
> To get the control instead before doing the EditLabel() stuff.
> 
> Otherwise you may have to place your own edit control in there instead using 
> something like:
> 
> http://www.codeguru.com/cpp/controls/listview/advanced/article.php/c4179/
> 
> Tom

That's great that  you got it working.  This is going to make everything 
uppercase.  Is that what you wanted?  If so, good stuff!  Thanks for posting 
the final solution.  It's always interesting to have threads completed.

Tom

"Matt Jacobi" <MattJacobi@discussions.microsoft.com> wrote in message 
news:E0A67451-D88F-4E82-90E1-FF561B012720@microsoft.com...
> Tom,
>
> Thanks for your help. By looking at the source code of the edit control 
> you
> pointed me to, plus some further Googling based on what I saw there, I was
> able to come up with a solution. All I had to do was override one function 
> in
> my class.
>
> Here is what I came up with:
>
> BOOL SerialNumberList::PreTranslateMessage(MSG* pMsg) {
>    if (pMsg->message == WM_CHAR) {
>        pMsg->wParam = toupper(pMsg->wParam);
>    }
>    return CListCtrl::PreTranslateMessage(pMsg);
> }
>
> Thanks again for your help!
> -- Matt

Like Tom pointed out the solution that you have posted will make everything 
typed upper case, and might be ok in your case.

The correct solution is to catch the LVN_BEGINLABELEDIT message of the list 
control and change the style of the edit control.

class CMyListCtrl : public CListCtrl
{
 DECLARE_DYNAMIC(CMyListCtrl)

public:
 CMyListCtrl() {}
 virtual ~CMyListCtrl() {}

protected:
 afx_msg void OnLvnBeginlabeledit(NMHDR *pNMHDR, LRESULT *pResult);
 DECLARE_MESSAGE_MAP()
};

// CMyListCtrl

IMPLEMENT_DYNAMIC(CMyListCtrl, CListCtrl)

BEGIN_MESSAGE_MAP(CMyListCtrl, CListCtrl)
 ON_NOTIFY_REFLECT(LVN_BEGINLABELEDIT, &CMyListCtrl::OnLvnBeginlabeledit)
END_MESSAGE_MAP()


void CMyListCtrl::OnLvnBeginlabeledit(NMHDR *pNMHDR, LRESULT *pResult)
{
 NMLVDISPINFO *pDispInfo = reinterpret_cast<NMLVDISPINFO*>(pNMHDR);

 CEdit *pEdit = GetEditControl();
 ASSERT(pEdit);
 pEdit->ModifyStyle(0,ES_UPPERCASE);

 *pResult = 0;
}



That way you can control this if they are editing a different column or item 
that does not need to be all upper case.


AliR.


"Tom Serface" <tom.nospam@camaswood.com> wrote in message 
news:uvcJHfdjIHA.4396@TK2MSFTNGP04.phx.gbl...
> That's great that  you got it working.  This is going to make everything 
> uppercase.  Is that what you wanted?  If so, good stuff!  Thanks for 
> posting the final solution.  It's always interesting to have threads 
> completed.
>
> Tom
>
> "Matt Jacobi" <MattJacobi@discussions.microsoft.com> wrote in message 
> news:E0A67451-D88F-4E82-90E1-FF561B012720@microsoft.com...
>> Tom,
>>
>> Thanks for your help. By looking at the source code of the edit control 
>> you
>> pointed me to, plus some further Googling based on what I saw there, I 
>> was
>> able to come up with a solution. All I had to do was override one 
>> function in
>> my class.
>>
>> Here is what I came up with:
>>
>> BOOL SerialNumberList::PreTranslateMessage(MSG* pMsg) {
>>    if (pMsg->message == WM_CHAR) {
>>        pMsg->wParam = toupper(pMsg->wParam);
>>    }
>>    return CListCtrl::PreTranslateMessage(pMsg);
>> }
>>
>> Thanks again for your help!
>> -- Matt
> 

Thanks for the information AliR. The code you posted is somewhat similar to 
where I was at at one point along the way, but I simplified it down because 
this is a very simple implementation with two columns: one fixed, one 
editable. As far as this grid is concerned, I don't ever see there being 
multiple editable columns. However, this is def good knowledge to have for 
the future in case a similar situation ever arises. Thanks again for the help.

-- Matt

"AliR (VC++ MVP)" wrote:

> Like Tom pointed out the solution that you have posted will make everything 
> typed upper case, and might be ok in your case.
> 
> The correct solution is to catch the LVN_BEGINLABELEDIT message of the list 
> control and change the style of the edit control.
> 
> class CMyListCtrl : public CListCtrl
> {
>  DECLARE_DYNAMIC(CMyListCtrl)
> 
> public:
>  CMyListCtrl() {}
>  virtual ~CMyListCtrl() {}
> 
> protected:
>  afx_msg void OnLvnBeginlabeledit(NMHDR *pNMHDR, LRESULT *pResult);
>  DECLARE_MESSAGE_MAP()
> };
> 
> // CMyListCtrl
> 
> IMPLEMENT_DYNAMIC(CMyListCtrl, CListCtrl)
> 
> BEGIN_MESSAGE_MAP(CMyListCtrl, CListCtrl)
>  ON_NOTIFY_REFLECT(LVN_BEGINLABELEDIT, &CMyListCtrl::OnLvnBeginlabeledit)
> END_MESSAGE_MAP()
> 
> 
> void CMyListCtrl::OnLvnBeginlabeledit(NMHDR *pNMHDR, LRESULT *pResult)
> {
>  NMLVDISPINFO *pDispInfo = reinterpret_cast<NMLVDISPINFO*>(pNMHDR);
> 
>  CEdit *pEdit = GetEditControl();
>  ASSERT(pEdit);
>  pEdit->ModifyStyle(0,ES_UPPERCASE);
> 
>  *pResult = 0;
> }
> 
> 
> 
> That way you can control this if they are editing a different column or item 
> that does not need to be all upper case.
> 
> 
> AliR.
> 
> 
> "Tom Serface" <tom.nospam@camaswood.com> wrote in message 
> news:uvcJHfdjIHA.4396@TK2MSFTNGP04.phx.gbl...
> > That's great that  you got it working.  This is going to make everything 
> > uppercase.  Is that what you wanted?  If so, good stuff!  Thanks for 
> > posting the final solution.  It's always interesting to have threads 
> > completed.
> >
> > Tom
> >
> > "Matt Jacobi" <MattJacobi@discussions.microsoft.com> wrote in message 
> > news:E0A67451-D88F-4E82-90E1-FF561B012720@microsoft.com...
> >> Tom,
> >>
> >> Thanks for your help. By looking at the source code of the edit control 
> >> you
> >> pointed me to, plus some further Googling based on what I saw there, I 
> >> was
> >> able to come up with a solution. All I had to do was override one 
> >> function in
> >> my class.
> >>
> >> Here is what I came up with:
> >>
> >> BOOL SerialNumberList::PreTranslateMessage(MSG* pMsg) {
> >>    if (pMsg->message == WM_CHAR) {
> >>        pMsg->wParam = toupper(pMsg->wParam);
> >>    }
> >>    return CListCtrl::PreTranslateMessage(pMsg);
> >> }
> >>
> >> Thanks again for your help!
> >> -- Matt
> > 
> 
> 
> 

That's fine.  I just wanted to post the solution in case someone else needs 
a solution to this problem.

When it comes to simplicity, they are both two lines of code!  Your if 
statement will get evaluated something like a 1000 times a second as the 
mouse moves around the list control (as the PreTranslateMessage gets called 
for every message that gets sent to the list control). Where the 
LVN_BEGINLABELEDIT message will only get sent when the label is about to be 
edited.  Therefore I don't think the argument that one is simpler than the 
other is valid.

AliR.


"Matt Jacobi" <MattJacobi@discussions.microsoft.com> wrote in message 
news:D69E60B9-16C5-4AC9-9F04-36C438F9D049@microsoft.com...
> Thanks for the information AliR. The code you posted is somewhat similar 
> to
> where I was at at one point along the way, but I simplified it down 
> because
> this is a very simple implementation with two columns: one fixed, one
> editable. As far as this grid is concerned, I don't ever see there being
> multiple editable columns. However, this is def good knowledge to have for
> the future in case a similar situation ever arises. Thanks again for the 
> help.
>
> -- Matt
>
> "AliR (VC++ MVP)" wrote:
>
>> Like Tom pointed out the solution that you have posted will make 
>> everything
>> typed upper case, and might be ok in your case.
>>
>> The correct solution is to catch the LVN_BEGINLABELEDIT message of the 
>> list
>> control and change the style of the edit control.
>>
>> class CMyListCtrl : public CListCtrl
>> {
>>  DECLARE_DYNAMIC(CMyListCtrl)
>>
>> public:
>>  CMyListCtrl() {}
>>  virtual ~CMyListCtrl() {}
>>
>> protected:
>>  afx_msg void OnLvnBeginlabeledit(NMHDR *pNMHDR, LRESULT *pResult);
>>  DECLARE_MESSAGE_MAP()
>> };
>>
>> // CMyListCtrl
>>
>> IMPLEMENT_DYNAMIC(CMyListCtrl, CListCtrl)
>>
>> BEGIN_MESSAGE_MAP(CMyListCtrl, CListCtrl)
>>  ON_NOTIFY_REFLECT(LVN_BEGINLABELEDIT, &CMyListCtrl::OnLvnBeginlabeledit)
>> END_MESSAGE_MAP()
>>
>>
>> void CMyListCtrl::OnLvnBeginlabeledit(NMHDR *pNMHDR, LRESULT *pResult)
>> {
>>  NMLVDISPINFO *pDispInfo = reinterpret_cast<NMLVDISPINFO*>(pNMHDR);
>>
>>  CEdit *pEdit = GetEditControl();
>>  ASSERT(pEdit);
>>  pEdit->ModifyStyle(0,ES_UPPERCASE);
>>
>>  *pResult = 0;
>> }
>>
>>
>>
>> That way you can control this if they are editing a different column or 
>> item
>> that does not need to be all upper case.
>>
>>
>> AliR.
>>
>>
>> "Tom Serface" <tom.nospam@camaswood.com> wrote in message
>> news:uvcJHfdjIHA.4396@TK2MSFTNGP04.phx.gbl...
>> > That's great that  you got it working.  This is going to make 
>> > everything
>> > uppercase.  Is that what you wanted?  If so, good stuff!  Thanks for
>> > posting the final solution.  It's always interesting to have threads
>> > completed.
>> >
>> > Tom
>> >
>> > "Matt Jacobi" <MattJacobi@discussions.microsoft.com> wrote in message
>> > news:E0A67451-D88F-4E82-90E1-FF561B012720@microsoft.com...
>> >> Tom,
>> >>
>> >> Thanks for your help. By looking at the source code of the edit 
>> >> control
>> >> you
>> >> pointed me to, plus some further Googling based on what I saw there, I
>> >> was
>> >> able to come up with a solution. All I had to do was override one
>> >> function in
>> >> my class.
>> >>
>> >> Here is what I came up with:
>> >>
>> >> BOOL SerialNumberList::PreTranslateMessage(MSG* pMsg) {
>> >>    if (pMsg->message == WM_CHAR) {
>> >>        pMsg->wParam = toupper(pMsg->wParam);
>> >>    }
>> >>    return CListCtrl::PreTranslateMessage(pMsg);
>> >> }
>> >>
>> >> Thanks again for your help!
>> >> -- Matt
>> >
>>
>>
>> 

Hi Ali,

If that works then you are correct that it is a better solution, but we were 
having trouble getting the style to change.  Maybe the secret is to change 
the style before the control is actually created.  I forgot that there are 
some styles that can't be changed afterwards.  If this is called before the 
window is created then perhaps it could work, but otherwise it looks like 
Matt may have the same result.

Tom

"AliR (VC++ MVP)" <AliR@online.nospam> wrote in message 
news:AVTFj.10337$qS5.458@nlpi069.nbdc.sbc.com...
> That's fine.  I just wanted to post the solution in case someone else 
> needs a solution to this problem.
>
> When it comes to simplicity, they are both two lines of code!  Your if 
> statement will get evaluated something like a 1000 times a second as the 
> mouse moves around the list control (as the PreTranslateMessage gets 
> called for every message that gets sent to the list control). Where the 
> LVN_BEGINLABELEDIT message will only get sent when the label is about to 
> be edited.  Therefore I don't think the argument that one is simpler than 
> the other is valid.
>
> AliR.

I tested the code that I posted, and it worked find.

AliR.


"Tom Serface" <tom.nospam@camaswood.com> wrote in message 
news:87491389-B4BA-4B23-B82B-627CC21D177D@microsoft.com...
> Hi Ali,
>
> If that works then you are correct that it is a better solution, but we 
> were having trouble getting the style to change.  Maybe the secret is to 
> change the style before the control is actually created.  I forgot that 
> there are some styles that can't be changed afterwards.  If this is called 
> before the window is created then perhaps it could work, but otherwise it 
> looks like Matt may have the same result.
>
> Tom
>
> "AliR (VC++ MVP)" <AliR@online.nospam> wrote in message 
> news:AVTFj.10337$qS5.458@nlpi069.nbdc.sbc.com...
>> That's fine.  I just wanted to post the solution in case someone else 
>> needs a solution to this problem.
>>
>> When it comes to simplicity, they are both two lines of code!  Your if 
>> statement will get evaluated something like a 1000 times a second as the 
>> mouse moves around the list control (as the PreTranslateMessage gets 
>> called for every message that gets sent to the list control). Where the 
>> LVN_BEGINLABELEDIT message will only get sent when the label is about to 
>> be edited.  Therefore I don't think the argument that one is simpler than 
>> the other is valid.
>>
>> AliR.
> 

That's great.  I learned something new.  The LVN_BEGINLABELEDIT must be 
fired before the window is created or something like that.  Thanks.

Tom

"AliR (VC++ MVP)" <AliR@online.nospam> wrote in message 
news:OpUFj.10343$qS5.9278@nlpi069.nbdc.sbc.com...
>I tested the code that I posted, and it worked find.
>
> AliR.
>
>
> "Tom Serface" <tom.nospam@camaswood.com> wrote in message 
> news:87491389-B4BA-4B23-B82B-627CC21D177D@microsoft.com...
>> Hi Ali,
>>
>> If that works then you are correct that it is a better solution, but we 
>> were having trouble getting the style to change.  Maybe the secret is to 
>> change the style before the control is actually created.  I forgot that 
>> there are some styles that can't be changed afterwards.  If this is 
>> called before the window is created then perhaps it could work, but 
>> otherwise it looks like Matt may have the same result.
>>
>> Tom

The edit control is already created when LVN_BEGINLABELEDIT is sent, if you 
look inside the CWnd * you will see that it has a valid HWND.

I'm not a 100% sure where you guys where setting the ES_UPPERCASE style. 
But as far as I can tell, it is something you can do on the fly.

AliR.


"Tom Serface" <tom.nospam@camaswood.com> wrote in message 
news:99E5F44C-59CB-47C3-831D-104CF034DDBC@microsoft.com...
> That's great.  I learned something new.  The LVN_BEGINLABELEDIT must be 
> fired before the window is created or something like that.  Thanks.
>
> Tom
>
> "AliR (VC++ MVP)" <AliR@online.nospam> wrote in message 
> news:OpUFj.10343$qS5.9278@nlpi069.nbdc.sbc.com...
>>I tested the code that I posted, and it worked find.
>>
>> AliR.
>>
>>
>> "Tom Serface" <tom.nospam@camaswood.com> wrote in message 
>> news:87491389-B4BA-4B23-B82B-627CC21D177D@microsoft.com...
>>> Hi Ali,
>>>
>>> If that works then you are correct that it is a better solution, but we 
>>> were having trouble getting the style to change.  Maybe the secret is to 
>>> change the style before the control is actually created.  I forgot that 
>>> there are some styles that can't be changed afterwards.  If this is 
>>> called before the window is created then perhaps it could work, but 
>>> otherwise it looks like Matt may have the same result.
>>>
>>> Tom
> 

Yeah, I must have been missing something easy... thanks for the heads-up. 
It's not something I use very often, but I won't forget that one again.

Tom

"AliR (VC++ MVP)" <AliR@online.nospam> wrote in message 
news:VDVFj.8212$Rq1.2314@nlpi068.nbdc.sbc.com...
> The edit control is already created when LVN_BEGINLABELEDIT is sent, if 
> you look inside the CWnd * you will see that it has a valid HWND.
>
> I'm not a 100% sure where you guys where setting the ES_UPPERCASE style. 
> But as far as I can tell, it is something you can do on the fly.
>
> AliR.