HI all

I am run this simple query on sql 2008  and getting erro

declare @sql as varchar(50)

select @sql='select order_trn.fac_order,order_Trn.article_no from order_trn 
where order_trn.fac_order like 'N-5%''

EXEC(@sql)


Please help
thanks

Hmmm, do you really need dynamic?
select @sql='select order_trn.fac_order,order_Trn.article_no from order_trn

where order_trn.fac_order like ''N-5%'''

See if the above works, I hope   you are aware of SQL Injection....





"Capri" <NoEmail@NoDomain.com> wrote in message 
news:B7906BDD-68F6-484C-9582-C2FC854F44E2@microsoft.com...
> HI all
>
> I am run this simple query on sql 2008  and getting erro
>
> declare @sql as varchar(50)
>
> select @sql='select order_trn.fac_order,order_Trn.article_no from 
> order_trn where order_trn.fac_order like 'N-5%''
>
> EXEC(@sql)
>
>
> Please help
> thanks
> 

> select @sql='select order_trn.fac_order,order_Trn.article_no from 
> order_trn where order_trn.fac_order like 'N-5%''

You need to double-up single quotes within the string:

select @sql='select order_trn.fac_order,order_Trn.article_no from 
dbo.order_trn
where order_trn.fac_order like ''N-5%'''

A better method is specify a parameterized query and execute with 
sp_executesql:

DECLARE
	@sql nvarchar(max),
	@fac_order varchar(10);

SELECT @sql=N'select order_trn.fac_order,order_Trn.article_no from 
dbo.order_trn
where order_trn.fac_order like @fac_order';

SET @fac_order = 'N-5%';

EXEC sp_executesql @sql,
	N'@fac_order varchar(10)',
	@fac_order = @fac_order;
GO

However, I see no need to use a dynamic SQL Statement at all here; a simple 
parameterized query should do the job:

DECLARE
	@sql nvarchar(max),
	@fac_order varchar(10);

SET @fac_order = 'N-5%';

SELECT
    order_trn.fac_order,
    order_Trn.article_no
FROM dbo.order_trn
WHERE order_trn.fac_order LIKE @fac_order;

See Erland's article on dynamic SQL at 
http://www.sommarskog.se/dynamic_sql.html for details.

-- 
Hope this helps.

Dan Guzman
SQL Server MVP
http://weblogs.sqlteam.com/dang/

"Capri" <NoEmail@NoDomain.com> wrote in message 
news:B7906BDD-68F6-484C-9582-C2FC854F44E2@microsoft.com...
> HI all
>
> I am run this simple query on sql 2008  and getting erro
>
> declare @sql as varchar(50)
>
> select @sql='select order_trn.fac_order,order_Trn.article_no from 
> order_trn where order_trn.fac_order like 'N-5%''
>
> EXEC(@sql)
>
>
> Please help
> thanks
> 

> I am run this simple query on sql 2008  and getting erro

Next time, tell us the exact and complete error message that you are 
receiving.

Thank you very much,


"Dan Guzman" <guzmanda@nospam-online.sbcglobal.net> wrote in message 
news:ABCF440B-9C4F-4B69-A6AF-9B76312DC1BB@microsoft.com...
>> select @sql='select order_trn.fac_order,order_Trn.article_no from 
>> order_trn where order_trn.fac_order like 'N-5%''
>
> You need to double-up single quotes within the string:
>
> select @sql='select order_trn.fac_order,order_Trn.article_no from 
> dbo.order_trn
> where order_trn.fac_order like ''N-5%'''
>
> A better method is specify a parameterized query and execute with 
> sp_executesql:
>
> DECLARE
> @sql nvarchar(max),
> @fac_order varchar(10);
>
> SELECT @sql=N'select order_trn.fac_order,order_Trn.article_no from 
> dbo.order_trn
> where order_trn.fac_order like @fac_order';
>
> SET @fac_order = 'N-5%';
>
> EXEC sp_executesql @sql,
> N'@fac_order varchar(10)',
> @fac_order = @fac_order;
> GO
>
> However, I see no need to use a dynamic SQL Statement at all here; a 
> simple parameterized query should do the job:
>
> DECLARE
> @sql nvarchar(max),
> @fac_order varchar(10);
>
> SET @fac_order = 'N-5%';
>
> SELECT
>    order_trn.fac_order,
>    order_Trn.article_no
> FROM dbo.order_trn
> WHERE order_trn.fac_order LIKE @fac_order;
>
> See Erland's article on dynamic SQL at 
> http://www.sommarskog.se/dynamic_sql.html for details.
>
> -- 
> Hope this helps.
>
> Dan Guzman
> SQL Server MVP
> http://weblogs.sqlteam.com/dang/
>
> "Capri" <NoEmail@NoDomain.com> wrote in message 
> news:B7906BDD-68F6-484C-9582-C2FC854F44E2@microsoft.com...
>> HI all
>>
>> I am run this simple query on sql 2008  and getting erro
>>
>> declare @sql as varchar(50)
>>
>> select @sql='select order_trn.fac_order,order_Trn.article_no from 
>> order_trn where order_trn.fac_order like 'N-5%''
>>
>> EXEC(@sql)
>>
>>
>> Please help
>> thanks
>>